Skip to content

Conversation

@Lipata
Copy link
Member

@Lipata Lipata commented Aug 21, 2025

No description provided.

@Lipata Lipata requested a review from Copilot August 21, 2025 14:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the unnecessary hsla() function wrapper from CSS custom property references across multiple template files. The change simplifies color declarations by directly using CSS custom properties instead of wrapping them in the hsla() function.

  • Removed hsla() wrapper from color CSS custom properties
  • Updated template files across Angular (igx-ts and igx-ts-legacy), Web Components, and React projects
  • Simplified CSS color declarations while maintaining the same visual output

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/igx-templates/igx-ts/tree/default/files/src/app/path/filePrefix.component.scss Removed hsla() wrapper from success color variable in tree component
packages/igx-templates/igx-ts-legacy/tree/default/files/src/app/path/filePrefix.component.scss Removed hsla() wrapper from success color variable in legacy tree component
packages/cli/templates/webcomponents/igc-ts/projects/_base/files/styles.css Removed hsla() wrapper from background color variable in Web Components template
packages/cli/templates/react/igr-ts/projects/_base/files/styles.css Removed hsla() wrapper from background color variable in React template

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@coveralls
Copy link

coveralls commented Aug 21, 2025

Coverage Status

coverage: 70.167%. remained the same
when pulling 8d347f2 on nalipiev/remove-hsla
into d71af0d on master.

@Lipata Lipata force-pushed the nalipiev/remove-hsla branch from 704535c to dda69bd Compare August 21, 2025 15:06
@Lipata Lipata changed the title chore: remove hsla function fix: remove hsla function Aug 21, 2025
@Lipata Lipata merged commit dfaf43a into master Aug 21, 2025
3 checks passed
@Lipata Lipata deleted the nalipiev/remove-hsla branch August 21, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants